Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow OCS resources as well #13714

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Allow OCS resources as well #13714

merged 2 commits into from
Jan 22, 2019

Conversation

nickvergessen
Copy link
Member

Better to look at the commits one by one

@nickvergessen nickvergessen added this to the Nextcloud 16 milestone Jan 21, 2019
ChristophWurst
ChristophWurst approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Code looks good! I guess we should also add this to the dev manual.

MorrisJobke
MorrisJobke approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke
Copy link
Member

PHPUnit fails :/

@nickvergessen
Copy link
Member Author

Fixed and also added tests for the new code

@rullzer
Copy link
Member

rullzer commented Jan 22, 2019

rebase and autosquash time!

@nickvergessen
Allow resources via OCS as well
f8b74cf 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Make RouteConfig strict
92edd40 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the feature/noid/ocs-resources branch from c24c102 to 92edd40 Compare January 22, 2019 13:19
@rullzer rullzer merged commit 0d33302 into master Jan 22, 2019
@rullzer rullzer deleted the feature/noid/ocs-resources branch January 22, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @MorrisJobke @rullzer @ChristophWurst